[#POOL-137] Inconsistent synchronization in GenericObjectPool; constant fields should be final

Commons Pool

Created: 18/May/09 12:13 AM Updated: 19/Jun/09 04:09 PM

Return to search

Component/s:

None

Affects Version/s:

None

Fix Version/s:

1.5

Time Tracking:

Not Specified

Resolution Date:

18/May/09 08:16 PM

Description

« Hide

_whenExhaustedAction is not always accessed using synchronization.

The private static Latch class appears to be used across threads, but has no synchronization.

The static class Config contains several fields which appear to be used as constants, however the fields are not final.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Repository	Revision	Date	User	Message
ASF	#776074	Mon May 18 20:13:07 UTC 2009	markt	Fix for ~~POOL-137~~. Correct inconsistent synchronization.
				Files Changed
				MODIFY /commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericObjectPool.java

Repository	Revision	Date	User	Message
ASF	#776855	Wed May 20 21:04:11 UTC 2009	markt	Address remaining concerns in ~~POOL-137~~. Sync access to Latch objects as they are used across multiple threads.
				Files Changed
				MODIFY /commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericObjectPool.java