Issue Details (XML | Word | Printable)

Key: POOL-133
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Mark Thomas
Reporter: Mark Thomas
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Commons Pool

Failed object creation may result in invalid active count in GKOP

Created: 17/Mar/09 09:09 PM   Updated: 19/Jun/09 04:12 PM
Return to search
Component/s: None
Affects Version/s: 1.4
Fix Version/s: 1.5

Time Tracking:
Not Specified

Resolution Date: 17/Mar/09 09:14 PM


 Description  « Hide
In GenericKeyedObjectPool.borrowObject() there are two instances of:

try {
_factory.destroyObject(key,pair.value);
synchronized (this) { pool.decrementActiveCount(); }
} catch (Exception e2) { // swallowed }

The decrementing of the active count should be moved to a finally block to ensure that it is always called even if destroyObject() throws an exception.

I think this is what DCP-34 is getting at.



 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
No work has yet been logged on this issue.