[#POOL-133] Failed object creation may result in invalid active count in GKOP

Commons Pool

Failed object creation may result in invalid active count in GKOP

Created: 17/Mar/09 09:09 PM Updated: 19/Jun/09 04:12 PM

Return to search

Component/s:

None

Affects Version/s:

1.4

Fix Version/s:

1.5

Time Tracking:

Not Specified

Resolution Date:

17/Mar/09 09:14 PM

Description

« Hide

In GenericKeyedObjectPool.borrowObject() there are two instances of:

try {
_factory.destroyObject(key,pair.value);
synchronized (this) { pool.decrementActiveCount(); }
} catch (Exception e2) { // swallowed }

The decrementing of the active count should be moved to a finally block to ensure that it is always called even if destroyObject() throws an exception.

I think this is what DCP-34 is getting at.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Repository	Revision	Date	User	Message
ASF	#755401	Tue Mar 17 21:12:56 UTC 2009	markt	Fix ~~POOL-133~~. Make sure active count is decremented even if destroyObject() throws an exception
				Files Changed
				MODIFY /commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericKeyedObjectPool.java

[ Permlink | « Hide ]

Mark Thomas added a comment - 17/Mar/09 09:14 PM

Fixed in r755401

Mark Thomas made changes - 17/Mar/09 09:14 PM

Field	Original Value	New Value
Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

[ Permlink | « Hide ]

Phil Steitz added a comment - 19/Jun/09 04:12 PM

Fixed in 1.5 release.

Phil Steitz made changes - 19/Jun/09 04:12 PM

Status

Resolved [ 5 ]

Closed [ 6 ]