[#POOL-122] java.util.Timer in EvictionTimer does not recover from OutOfMemoryError in Evictor

Commons Pool

java.util.Timer in EvictionTimer does not recover from OutOfMemoryError in Evictor

Created: 02/Feb/08 04:01 PM Updated: 19/Jun/09 04:13 PM

Return to search

Component/s:

None

Affects Version/s:

1.3, 1.4

Fix Version/s:

1.5

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	fixes_POOL-122.patch	2008-02-02 06:50 PM	Marcus Schulte	4 kB

Environment:

any

Resolution Date:

01/Apr/09 04:46 PM

Description

« Hide

GenericKeyedObjectPool.Evictor.run() catches and ignores Exceptions, but not Errors, like OOME. Consequently, when, due to load-peeks an OOME is thrown in the evictor's timer-thread it dies miserably and no eviction will happen again in any of the pools loaded within the same class-loader (because the eviction timer is a static member). Also, the creation of evicting pools will fail with IllegalStateException.

Possible fixes:
1. catch Throwable in GenericKeyedObjectPool.Evictor.run()
2. check and eventually re-instantiate the Eviction-Timer.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Marcus Schulte made changes - 02/Feb/08 06:50 PM

Field	Original Value	New Value
Attachment		fixes_POOL-122.patch [ 12374612 ]

Phil Steitz made changes - 02/Feb/08 08:31 PM

Affects Version/s		1.4 [ 12312868 ]
Fix Version/s		1.5 [ 12312915 ]

Mark Thomas made changes - 01/Apr/09 03:01 PM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

Joerg Schaible made changes - 01/Apr/09 04:39 PM

Status	Resolved [ 5 ]	Reopened [ 4 ]
Resolution	Fixed [ 1 ]

Mark Thomas made changes - 01/Apr/09 04:46 PM

Resolution		Fixed [ 1 ]
Status	Reopened [ 4 ]	Resolved [ 5 ]

Phil Steitz made changes - 19/Jun/09 04:13 PM

Status

Resolved [ 5 ]

Closed [ 6 ]