[#POOL-117] StackObjectPool, SoftReferenceObjectPool borrowObject can loop indefinitely when new instances fail validation

Commons Pool

StackObjectPool, SoftReferenceObjectPool borrowObject can loop indefinitely when new instances fail validation

Created: 19/Dec/07 11:12 PM Updated: 20/Dec/07 12:33 AM

Return to search

Component/s:

None

Affects Version/s:

1.3

Fix Version/s:

1.4

Time Tracking:

Not Specified

Issue Links:

Reference

This issue is related to:

~~POOL-91~~ StackObjectPool.borrowObject infinate loop when makeObject returns null

Resolution Date:

20/Dec/07 12:33 AM

Description

« Hide

The borrowObject methods in StackObjectPool, SoftReferenceObjectPool are synchronized and do not bound the number of attempts to create a valid instance when the pool is exhausted. When a new instance is created, if activation or validation fails, the code continues (without bound) to retry the make-activate-validate sequence. This can lead to an infinite loop if the factory is unable to create valid instances.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Phil Steitz added a comment - 19/Dec/07 11:28 PM

Fixed in 1.4 release branch in r605736 by modifying borrowObject to throw NoSuchElementException when activate or validate fails on newly created instances (consistent with GenericObjectPool)

Phil Steitz made changes - 20/Dec/07 12:31 AM

Field	Original Value	New Value
Link		This issue is related to ~~POOL-91~~ [ ~~POOL-91~~ ]

[ Permlink | « Hide ]

Phil Steitz added a comment - 20/Dec/07 12:33 AM

Both ~~POOL-91~~ and this issue have been resolved in svn trunk (2.0 development branch) and now the 1.4 release branch.

Phil Steitz made changes - 20/Dec/07 12:33 AM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]