[PIG-5311] POReservoirSample fails for more than Integer.MAX_VALUE records

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.18.0
• Hadoop Flags: Reviewed
• Assignee: Rohini Palaniswamy
• Reporter: Rohini Palaniswamy
• Created: 27/Oct/17 21:00
• Updated: 31/Dec/17 01:31
• Resolved: 31/Dec/17 01:31

Description

https://github.com/apache/pig/blob/branch-0.17/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POReservoirSample.java#L128

The rowProcessed is a int. When it exceeds the int range it wraps around and becomes a negative number throwing below exception. It needs to be changed to long.

Caused by: java.lang.IllegalArgumentException: bound must be positive
  at java.util.Random.nextInt(Random.java:388)
  at org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POReservoirSample.getNextTuple(POReservoirSample.java:128)
  at org.apache.pig.backend.hadoop.executionengine.physicalLayer.PhysicalOperator.processInput(PhysicalOperator.java:305)
  at org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POForEach.getNextTuple(POForEach.java:284)