[PIG-2074] When passing a parameter to Pig, if the value contains $ it has to be escaped because of a bug in PrecprocessorContext

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Duplicate
• Component/s: impl
• Assignee: Unassigned
• Reporter: Julien Le Dem
• Created: 13/May/11 20:57
• Updated: 22/Oct/12 22:36
• Resolved: 22/Oct/12 22:36

Description

This was raised while looking at PIG-1827

There seems to be a bug in PreprocessorContext:
http://svn.apache.org/viewvc/pig/trunk/src/org/apache/pig/tools/parameters/PreprocessorContext.java?view=markup

235 	//String litVal = Matcher.quoteReplacement(val);
236 	replaced_line = replaced_line.replaceFirst("\\$"+key, val);

the replacement (2nd) parameter of replaceFirst is not a plain string, it can contain references to the matched pattern like "$0" so $ in val must be escaped.
Does someone know why line 235 is commented out ?

Issue Links

• duplicates: PIG-2931 $ signs in the replacement string make parameter substitution fail