Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-910

Filter should override hasFilterRow() when filterRow() is overridden

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 4.3.0
    • None
    • None

    Description

      There're 3 Filters where filterRow() is overridden but hasFilterRow() is not:

          public boolean filterRow() {
      ./phoenix-core/src/main/java/org/apache/phoenix/filter/MultiKeyValueComparisonFilter.java
          public boolean filterRow() {
      ./phoenix-core/src/main/java/org/apache/phoenix/filter/RowKeyComparisonFilter.java
          public boolean filterRow() {
      ./phoenix-core/src/main/java/org/apache/phoenix/filter/SingleKeyValueComparisonFilter.java
      

      hasFilterRow() should be overridden and return true.

      Attachments

        1. 910-v2.txt
          0.9 kB
          Ted Yu
        2. 910-v1.txt
          2 kB
          Ted Yu

        Activity

          People

            yuzhihong@gmail.com Ted Yu
            yuzhihong@gmail.com Ted Yu
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: