[PHOENIX-4743] ALTER TABLE ADD COLUMN for global index should not modify HBase metadata if failed

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.15.0, 5.1.0
• Labels: phoenix-hardening
• Assignee: Sandeep Pal
• Reporter: Chinmay Kulkarni
• Created: 18/May/18 02:08
• Updated: 21/Dec/19 00:56
• Resolved: 27/Aug/19 00:51

Description

When you issue an "ALTER TABLE" for a global index to add a column, Phoenix throws a SQLException, but the HBase metadata for the global index table is still modified.

Steps to reproduce:

• Create the base data table: 

  create table if not exists z_base_table (id INTEGER not null primary key, host VARCHAR(10), flag boolean);

• Create a global index on top of this table: 

  create index global_z_index on z_base_table(HOST);

• Add a column to the global index table:

  alter table global_z_index add cf1.age INTEGER;

This will throw an exception in Phoenix, but HBase metadata for the global index table is still modified. Stack trace:

Error: ERROR 1010 (42M01): Not allowed to mutate table. Cannot add/drop column referenced by VIEW columnName=GLOBAL_Z_INDEX (state=42M01,code=1010)
 java.sql.SQLException: ERROR 1010 (42M01): Not allowed to mutate table. Cannot add/drop column referenced by VIEW columnName=GLOBAL_Z_INDEX
 at org.apache.phoenix.exception.SQLExceptionCode$Factory$1.newException(SQLExceptionCode.java:494)
 at org.apache.phoenix.exception.SQLExceptionInfo.buildException(SQLExceptionInfo.java:150)
 at org.apache.phoenix.schema.MetaDataClient.processMutationResult(MetaDataClient.java:3049)
 at org.apache.phoenix.schema.MetaDataClient.addColumn(MetaDataClient.java:3503)
 at org.apache.phoenix.schema.MetaDataClient.addColumn(MetaDataClient.java:3210)
 at org.apache.phoenix.jdbc.PhoenixStatement$ExecutableAddColumnStatement$1.execute(PhoenixStatement.java:1432)
 at org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:408)
 at org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:391)
 at org.apache.phoenix.call.CallRunner.run(CallRunner.java:53)
 at org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:390)
 at org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:378)
 at org.apache.phoenix.jdbc.PhoenixStatement.execute(PhoenixStatement.java:1825)
 at sqlline.Commands.execute(Commands.java:822)
 at sqlline.Commands.sql(Commands.java:732)
 at sqlline.SqlLine.dispatch(SqlLine.java:813)
 at sqlline.SqlLine.begin(SqlLine.java:686)
 at sqlline.SqlLine.start(SqlLine.java:398)
 at sqlline.SqlLine.main(SqlLine.java:291

 

Issue Links

• links to: GitHub Pull Request #569