[PHOENIX-4021] Remove CachingHTableFactory

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.11.0
• Fix Version/s: 4.12.0
• Labels: globalMutableSecondaryIndex
• Assignee: Geoffrey Jacoby
• Reporter: Geoffrey Jacoby
• Created: 13/Jul/17 21:37
• Updated: 19/Sep/17 14:50
• Resolved: 17/Jul/17 16:55

Description

CachingHTableFactory is used as a performance optimization when writing to global indexes so that HTable instances are cached and later automatically cleaned up, rather than instantiated each time we write to an index.

This should be removed for two reasons:

1. It opens us up to race conditions, because HTables aren't threadsafe, but CachingHTableFactory doesn't guard against two threads both grabbing the same HTable and using it simultaneously. Since all ops going through a region share the same IndexWriter and ParallelWriterIndexCommitter, and hence the same CachingHTableFactory, that means separate operations can both be holding the same HTable.

2. According to discussion on PHOENIX-3159, and offline discussions I've had with apurtell, HBase 1.x and above make creating throwaway HTable instances cheap so the caching is no longer needed.

For 4.x-HBase-1.x and master, we should remove CachingHTableFactory, and for 4.x-HBase-0.98, we should either get rid of it (if it's not too much of a perf hit) or at least make it threadsafe.

Issue Links

• is a child of: PHOENIX-4025 Make CachingHTableFactory thread-safe for 0.98 branch