[PDFBOX-815] PDFont.getEncodingManager is not thread safe; FIX included

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3.1
• Fix Version/s: 1.3.1
• Component/s: PDModel
• Assignee: Jukka Zitting
• Reporter: Timo Boehme
• Created: 03/Sep/10 07:34
• Updated: 26/Oct/10 09:34
• Resolved: 03/Sep/10 12:13

Description

In class PDFont calling static getEncodingManager is not thread safe. Two solutions:
(1) with lazy initialization (thread safe with Java 1.5 and later)
private static volatile EncodingManager encodingManager = null;

protected static EncodingManager getEncodingManager() {
if(encodingManager == null) {
synchronized ( PDFont.class )

{ if ( encodingManager == null ) encodingManager = new EncodingManager(); }

}
return encodingManager;
}

(2) create singleton at class initialization time
private static EncodingManager encodingManager = new EncodingManager();

protected static EncodingManager getEncodingManager()

{ return encodingManager; }