Uploaded image for project: 'Parquet'
  1. Parquet
  2. PARQUET-1159

[C++] Compatibility with C++ iterators

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Later
    • cpp-1.2.0
    • cpp-9.0.0
    • parquet-cpp
    • None

    Description

      There are some places where it would clean up the code quite a bit to use C++ STL iterators and be compatible with their APIs.

      Additionally, in this PR (https://github.com/apache/parquet-cpp/pull/403) I had to allocate a separate vector to hold byte swapped values, when what I really want to do is iterate over the existing values in reverse (starting at the last valid byte) so I don't have to copy them into a separate container. This can be done with a std::reverse_iterator which allows one to use the ++ operator everywhere.

      Attachments

        Activity

          People

            Unassigned Unassigned
            cpcloud Phillip Cloud
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: