[ORC-228] Make MemoryManagerImpl.ROWS_BETWEEN_CHECKS configurable

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.5.0
• Assignee: Eugene Koifman
• Reporter: Eugene Koifman
• Created: 10/Aug/17 22:43
• Updated: 14/May/18 22:24
• Resolved: 15/Aug/17 17:55

Description

currently addedRow() looks like

public void addedRow(int rows) throws IOException {
    rowsAddedSinceCheck += rows;
    if (rowsAddedSinceCheck >= ROWS_BETWEEN_CHECKS) {
      notifyWriters();
    }
  }

it would be convenient for testing to set ROWS_BETWEEN_CHECKS to a low value so that we can generate multiple stripes with very little data.

Currently the only way to do this is to create a new MemoryManager that overrides this method and install it via OrcFile.WriterOptions but this only works when you have control over creating the Writer.
For example org.apache.hadoop.hive.ql.io.orc.TestOrcRawRecordMerger.testRecordReaderNewBaseAndDelta()

There is no way to do this via some set of config params to make Hive query for example, create multiple stripes with little data.

Issue Links

• blocks: HIVE-17296 Acid tests with multiple splits
• is related to: HIVE-17089 make acid 2.0 the default
• links to: GitHub Pull Request #154