Issue Details (XML | Word | Printable)

Key: OPENJPA-259
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Unassigned
Reporter: Ognjen Blagojevic
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
OpenJPA

Ability to parse EJB QL multiline queries in orm.xml

Created: 13/Jun/07 11:33 AM   Updated: 19/Jun/07 09:51 PM
Return to search
Component/s: kernel
Affects Version/s: 0.9.7
Fix Version/s: 1.0.0

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works OPENJPA-259.patch 2007-06-13 05:28 PM Craig Russell 0.3 kB
Environment: Windows XP

Resolution Date: 16/Jun/07 06:54 AM


 Description  « Hide
Multiline queries in orm.xml like this one

<named-query name="Test.findAll">
   <query>
       select o
         from Test o
   </query>
</named-query>

Fail to execute with exception:

Error message: org.apache.openjpa.kernel.jpql.TokenMgrError: Lexical error at line 1, column 10. Encountered: "\n" (10), after : ""

Please, add the possibility to the parser to handle multiline queries.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Repository Revision Date User Message
ASF #547872 Sat Jun 16 06:54:12 UTC 2007 pcl OPENJPA-259. Applied Craig's patch (minus the ACK char; maybe Craig meant ^L instead?), and added a test case. The test uses dynamic JPQL, but the parser change should work for XML-based named queries also, and it seems fair to allow newlines in dynamic strings as well.
Files Changed
MODIFY /openjpa/trunk/openjpa-kernel/src/main/jjtree/org/apache/openjpa/kernel/jpql/JPQL.jjt
ADD /openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/query/TestNewlinesInQueries.java (from /openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/query/TestQueryExcludingSubclasses.java)