Ability to parse EJB QL multiline queries in orm.xml

• Key: OPENJPA-259
• Type: Improvement
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Unassigned
• Reporter: Ognjen Blagojevic
• Component/s: kernel
• Affects Version/s: 0.9.7
• Fix Version/s: 1.0.0

Description

Multiline queries in orm.xml like this one

<named-query name="Test.findAll">
   <query>
       select o
         from Test o
   </query>
</named-query>

Fail to execute with exception:

Error message: org.apache.openjpa.kernel.jpql.TokenMgrError: Lexical error at line 1, column 10. Encountered: "\n" (10), after : ""

Please, add the possibility to the parser to handle multiline queries.

Comments

This patch might do the trick. Anyone want to give it a try?

[Craig Russell]

Thanks for committing the patch and adding a test case.

The \f" was not accidental. It's white space as defined in the Java Language manual, which calls it "form feed". I added all the white space from the manual.

[Patrick Linskey]

> The \f" was not accidental. It's white space as defined in the
> Java Language manual, which calls it "form feed". I added
> all the white space from the manual.

Surely they meant \l (^L, or ASCII 12), not \f (^F, ASCII 6).

[Craig Russell]

Well, \n isn't ascii 14 and \t isn't ascii 20. They're just letters and don't translate literally into ascii.

[Patrick Linskey]

Sure enough. I somehow never noticed that the escape characters didn't correspond to their ASCII equivalents.