Exception prefixes should be human-readable

• Key: OPENJPA-176
• Type: Improvement
• Status: Resolved
• Resolution: Fixed
• Priority: Trivial
• Assignee: Marc Prud'hommeaux
• Reporter: Marc Prud'hommeaux
• Component/s: diagnostics
• Affects Version/s: 0.9.0, 0.9.6
• Fix Version/s: 0.9.7

Description

OpenJPA prefixes all exception messages with a string of the form "<exception type|is fatal|version>", restulting in strings like "<4|false|0.9.6-incubating> org.apache.openjpa.persistence.PersistenceException". This isn't very useful to the casual observer, since no translation of the meaning of the fields is done.

it would be nice if we translated the fatal and type parameters, so that the string looked like "<user-error|recoverable|0.9.6-incubating>".

Comments

[Marc Prud'hommeaux]

The attached patch will change the prefix to look like, for example: "<0.9.6-incubating fatal user error> org.apache.openjpa.persistence.PersistenceException".

Any objections?

[Craig Russell]

I like it.

What if the type is not one of the expected types? Perhaps we want to identify this case? Such as "unexpected error" or something.

It looks like we just use type + " error" if the type isn't recognized.

+1 as it is, but I'm not opposed to changing type + " error" to "unexpected error" or something similar.

[Marc Prud'hommeaux]

Implemented patch.