EntityManager.getDelegate should throw an IllegalStateException

• Key: OPENJPA-116
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: Kevin Sutter
• Reporter: Michael Dick
• Fix Version/s: 0.9.7

Description

EntityManager.getDelegate() should throw an IllegalStateException if the EntityManager has been closed.

I noticed then when debugging other problems. According to the javadoc http://java.sun.com/javaee/5/docs/api/javax/persistence/EntityManager.html#getDelegate() we need to throw an exception if the EM has been closed.

In case I missed anything here's what I did to reproduce the problem.


        EntityManagerFactory _emf = Persistence.createEntityManagerFactory("test");

        EntityManager em = _emf.createEntityManager();

        em.close();

        try {
            Object o = em.getDelegate();
            fail();
        }
        catch(IllegalStateException ise) {
            System.out.println("Caught expected exception");
        }

Comments

This issue was temporarily resolved with the patch that Mike provided. Abe has since changed the processing in this area of the code and, thus, the actual call to assertOpen() has been replaced with the assertNotCloseInvoked() method, but the same result still happens.