Improved configuration error detection and help

• Key: OPENEJB-743
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Critical
• Assignee: David Blevins
• Reporter: David Blevins
• Component/s: configuration
• Affects Version/s: 3.0-beta-1
• Fix Version/s: 3.0-beta-2

Description

Strong detection on possible invalid configuration catches most non-functional declarations and lists possible and *functional* declarations.

org.apache.openejb.OpenEJBException: Failed Configuring Service(id=mq_connector): Cannot determine a provider for Resource(id=mq_connector, type=null, provider=null).

Possible valid configurations might be:
  <Resource id="mq_connector" type="javax.sql.DataSource"/>
  <Resource id="mq_connector" type="DataSource"/>
  <Resource id="mq_connector" type="ActiveMQResourceAdapter"/>
  <Resource id="mq_connector" type="javax.jms.ConnectionFactory"/>
  <Resource id="mq_connector" type="javax.jms.QueueConnectionFactory"/>
  <Resource id="mq_connector" type="javax.jms.TopicConnectionFactory"/>
  <Resource id="mq_connector" type="QueueConnectionFactory"/>
  <Resource id="mq_connector" type="TopicConnectionFactory"/>
  <Resource id="mq_connector" type="javax.jms.Queue"/>
  <Resource id="mq_connector" type="Queue"/>
  <Resource id="mq_connector" type="javax.jms.Topic"/>
  <Resource id="mq_connector" type="Topic"/>
  <Resource id="mq_connector" type="org.omg.CORBA.ORB"/>
  <Resource id="mq_connector" type="ORB"/>
  <Resource id="mq_connector" type="javax.mail.Session"/>
at org.apache.openejb.config.ConfigurationFactory.configureService(ConfigurationFactory.java:554)
at org.apache.openejb.config.ConfigurationFactory.getOpenEjbConfiguration(ConfigurationFactory.java:257)
at org.apache.openejb.assembler.classic.Assembler.build(Assembler.java:242)
at org.apache.openejb.OpenEJB$Instance.<init>(OpenEJB.java:149)
at org.apache.openejb.OpenEJB.init(OpenEJB.java:293)
at org.apache.openejb.server.Server.init(Server.java:63)
at org.apache.openejb.server.Main.initServer(Main.java:155)
at org.apache.openejb.server.Main.main(Main.java:128)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.apache.openejb.cli.MainImpl.main(MainImpl.java:151)
at org.apache.openejb.cli.Bootstrap.main(Bootstrap.java:102)

Comments

$ svn ci
Sending assembly/openejb-tomcat/openejb-tomcat-webapp/src/main/resources/META-INF/org.apache.openejb.tomcat/service-jar.xml
Sending container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
Sending container/openejb-core/src/main/java/org/apache/openejb/config/ConfigurationFactory.java
Sending container/openejb-core/src/main/java/org/apache/openejb/config/ServiceUtils.java
Sending container/openejb-core/src/main/java/org/apache/openejb/config/sys/Openejb.java
Sending container/openejb-core/src/main/resources/META-INF/org.apache.openejb/service-jar.xml
Sending container/openejb-core/src/main/resources/default.openejb.conf
Sending container/openejb-core/src/main/resources/org/apache/openejb/config/Messages.properties
Sending container/openejb-core/src/main/resources/org/apache/openejb/util/resources/Messages.properties
Adding container/openejb-core/src/test/java/org/apache/openejb/assembler/classic/ResourceInfoComparatorTest.java
Transmitting file data ..........
Committed revision 607392.

[David Blevins]

upgrading for release notes purposes