iTest: StatefulLocalJndiTests

• Key: OPENEJB-172
• Type: Sub-task
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Mohammad Nour
• Reporter: David Blevins
• Component/s: ejb3 simplified
• Affects Version/s: (trunk/openejb3)
• Fix Version/s: (trunk/openejb3)

Description

tests that an ejb3 stateful bean can be looked up in global JNDI via it's backwards compatible local home interface.

Comments

[Mohammad Nour]

- This patch solves the iTests errors that were showing as a result of the patch of OPENEJB-147.
- *Completed* waiting for review.

[Mohammad Nour]

Use this patch not the other one.

[Mohammad Nour]

- *Use* patch#*2*, *don't use* patch#*1*.

[Jacek Laskowski]

After some changes to your latest patch (classes/interfaces doubled in their files) had been applied, the build went file (!)

[INFO] ------------------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESSFUL
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2 minutes 25 seconds
[INFO] Finished at: Sat Sep 23 08:49:26 CEST 2006
[INFO] Final Memory: 26M/254M
[INFO] ------------------------------------------------------------------------

I'm looking at the changes and if they look fine, I'll commit them. Stay tuned.

[Mohammad Nour]

Completed

[Mohammad Nour]

Resolved

[Jacek Laskowski]

Patch committed.

A few comments to improve your patching skills ;-)

1/ Do not use tabs as indent characters
2/ Make sure that a patch works before submitting it to jira (double- or triple-check it with an empty m2 local repo)
3/ Add ASF 2.0 license header to every source file
4/ Do not use @author tags - @version $Rev$ $Date$ is enough
5/ Remove (svn rm) rather than empty files so they won't pollute the repo or 'svn mv' them to keep their history

$ svn ci -m 'OPENEJB-172 - iTest: StatefulLocalJndiTests' .
Sending container/openejb-core/src/main/java/org/openejb/util/Index.java
Sending container/openejb-core/src/main/resources/META-INF/org.openejb/spring.xml
Sending openejb-itests/src/main/java/org/openejb/test/stateful/BasicStatefulTestClient.java
Sending openejb-itests/src/main/java/org/openejb/test/stateful/StatefulLocalTestSuite.java
Adding openejb-itests/src/main/java/org/openejb/test/stateless/BasicStatelessLocalTestClient.java
Deleting openejb-itests/src/main/java/org/openejb/test/stateless/BasicStatelessTestLocalClient.java
Sending openejb-itests/src/main/java/org/openejb/test/stateless/StatelessLocalTestSuite.java
Sending openejb-itests/src/main/java/org/openejb/test/stateless/StatelessPojoLocalJndiTests.java
Sending openejb-itests/src/main/java/org/openejb/test/stateless/StatelessTestSuite.java
Sending openejb-itests/src/main/resources/META-INF/ejb-jar.xml
Transmitting file data .........
Committed revision 449211.