Added 'openejb.vendor.config' property settable to any of: geronimo, glassfish, jboss, weblogic

• Key: OPENEJB-1006
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: David Blevins
• Reporter: Fredrik Jonson
• Component/s: deployment
• Affects Version/s: 3.0, 3.1
• Fix Version/s: 3.0.1, 3.1.1

Description

When a project's target environment is both Geronimo and Glassfish it is convenient if geronimo does not interfere with the sun specific deployment descriptors, such as sun-ejb-jar.xml. By default openejb currently parses both openejb-jar.xml and sun-ejb-jar.xm - which may cause deployment failures when the sun descriptor contains configurations specifically tailored for Glassfish.

The goal of this issue is to make automatic inclusion of the sun-specific deployment descriptors optional.

Comments

[Fredrik Jonson]

This is a simplistic patch that excludes the SunConverter from the configuration chain when the system property openejb.sunconfig.skip is set to true.

This is based on the openejb-3.0.x branch rev 751256.

[David Blevins]

Went with a very similar approach:

        // By default all vendor support is enabled
        Set<Vendor> support = Options.getEnums(SystemInstance.get().getProperties(), "openejb.vendor.config", Vendor.values());

        if (support.contains(Vendor.GERONIMO) || System.getProperty(DUCT_TAPE_PROPERTY) != null) {
            chain.add(new OpenEjb2Conversion());
        }

        if (support.contains(Vendor.GLASSFISH)) {
            chain.add(new SunConversion());
        }

        if (support.contains(Vendor.WEBLOGIC)) {
            chain.add(new WlsConversion());
        }

Adding container/openejb-core/src/main/java/org/apache/openejb/Vendor.java
Sending container/openejb-core/src/main/java/org/apache/openejb/config/ConfigurationFactory.java
Sending container/openejb-core/src/main/java/org/apache/openejb/util/Options.java
Transmitting file data ...
Committed revision 751333.

Ok, and here's the 3.0.1 branch commit:

Adding container/openejb-core/src/main/java/org/apache/openejb/Vendor.java
Sending container/openejb-core/src/main/java/org/apache/openejb/config/ConfigurationFactory.java
Adding container/openejb-core/src/main/java/org/apache/openejb/util/Options.java
Transmitting file data ..
Committed revision 751341.