[OOZIE-3295] Flaky test TestSLACalculatorMemory#testAddMultipleRestartRemoveMultipleInstrumentedCorrectly

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.1.0
• Component/s: core, tests
• Assignee: Peter Bacsko
• Reporter: Peter Bacsko
• Created: 21/Jun/18 14:36
• Updated: 07/Dec/22 13:26
• Resolved: 21/Jun/18 21:06

Description

The test TestSLACalculatorMemory.testAddMultipleRestartRemoveMultipleInstrumentedCorrectly can fail with the following error:

junit.framework.AssertionFailedError: SLA map size after update all should be 2. An instance of SLACalcStatus was removed expected:<2> but was:<1>
	at junit.framework.Assert.fail(Assert.java:57)
	at junit.framework.Assert.failNotEquals(Assert.java:329)
	at junit.framework.Assert.assertEquals(Assert.java:78)
	at junit.framework.Assert.assertEquals(Assert.java:159)
	at junit.framework.TestCase.assertEquals(TestCase.java:316)
	at org.apache.oozie.sla.TestSLACalculatorMemory.testAddMultipleRestartRemoveMultipleInstrumentedCorrectly(TestSLACalculatorMemory.java:1084)

The problem is the following setting:

slaRegBean1.setExpectedDuration(123);

The expected duration should not be set for such a small value (123 msecs). On a slow machine, SLA calculator might detect that this particular SLA has been missed. It must be increased to a higher value.

Issue Links

• is related to: OOZIE-3683 Fix intermittent unit test failure in testLoadOnRestart