[OOZIE-2955] [oozie-client] Fix Findbugs warnings

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.1.0
• Component/s: build, client
• Assignee: Kinga Marton
• Reporter: Jan Hentschel
• Created: 17/Jun/17 18:38
• Updated: 02/Oct/19 17:28
• Resolved: 02/Jul/18 10:09

Description

Currently Findbugs complains about the following warnings related to the reliance on the default encoding in the oozie-client module:

[INFO] Found reliance on default encoding in org.apache.oozie.cli.CLIParser.showHelp(CommandLine): new java.io.PrintWriter(OutputStream) [org.apache.oozie.cli.CLIParser] At CLIParser.java:[line 169]
[INFO] Found reliance on default encoding in org.apache.oozie.cli.OozieCLI.getConfiguration(OozieClient, CommandLine): new java.io.FileReader(File) [org.apache.oozie.cli.OozieCLI] At OozieCLI.java:[line 845]
[INFO] Found reliance on default encoding in org.apache.oozie.cli.OozieCLI.validateCommandV41(CommandLine): new java.io.FileReader(File) [org.apache.oozie.cli.OozieCLI] At OozieCLI.java:[line 2171]
[INFO] Found reliance on default encoding in org.apache.oozie.client.AuthOozieClient.readAuthToken(): new java.io.FileReader(File) [org.apache.oozie.client.AuthOozieClient] At AuthOozieClient.java:[line 218]
[INFO] Found reliance on default encoding in org.apache.oozie.client.AuthOozieClient.writeAuthToken(AuthenticatedURL$Token): new java.io.FileWriter(File) [org.apache.oozie.client.AuthOozieClient] At AuthOozieClient.java:[line 248]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient.getSupportedProtocolVersions(): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient] At OozieClient.java:[line 412]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$BulkResponseStatus.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$BulkResponseStatus] At OozieClient.java:[line 1693]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$BundleJobInfo.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$BundleJobInfo] At OozieClient.java:[line 1502]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$BundleJobsStatus.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$BundleJobsStatus] At OozieClient.java:[line 1667]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$CoordActionInfo.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$CoordActionInfo] At OozieClient.java:[line 1522]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$CoordActionsKill.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$CoordActionsKill] At OozieClient.java:[line 1720]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$CoordIgnore.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$CoordIgnore] At OozieClient.java:[line 1743]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$CoordJobInfo.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$CoordJobInfo] At OozieClient.java:[line 1455]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$CoordJobsStatus.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$CoordJobsStatus] At OozieClient.java:[line 1640]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$CoordRerun.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$CoordRerun] At OozieClient.java:[line 1773]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$GetBuildVersion.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$GetBuildVersion] At OozieClient.java:[line 2168]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$GetInstrumentation.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$GetInstrumentation] At OozieClient.java:[line 2907]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$GetMetrics.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$GetMetrics] At OozieClient.java:[line 2674]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$GetQueueDump.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$GetQueueDump] At OozieClient.java:[line 2532]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$GetSystemMode.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$GetSystemMode] At OozieClient.java:[line 2126]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$JMSInfo.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$JMSInfo] At OozieClient.java:[line 1005]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$JMSTopic.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$JMSTopic] At OozieClient.java:[line 1218]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$JobIdAction.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$JobIdAction] At OozieClient.java:[line 2066]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$JobInfo.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$JobInfo] At OozieClient.java:[line 986]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$JobMetadata.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$JobMetadata] At OozieClient.java:[line 1367]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$JobSubmit.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$JobSubmit] At OozieClient.java:[line 717]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$JobsAction.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$JobsAction] At OozieClient.java:[line 772]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$JobsStatus.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$JobsStatus] At OozieClient.java:[line 1613]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$ListShareLib.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$ListShareLib] At OozieClient.java:[line 2269]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$MapClientCallable.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$MapClientCallable] At OozieClient.java:[line 610]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$SlaInfo.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$SlaInfo] At OozieClient.java:[line 2043]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$Status.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$Status] At OozieClient.java:[line 2509]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$UpdateCoord.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$UpdateCoord] At OozieClient.java:[line 833]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$UpdateSharelib.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$UpdateSharelib] At OozieClient.java:[line 2227]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$ValidateXML.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$ValidateXML] At OozieClient.java:[line 2201]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$WfsForCoordAction.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$WfsForCoordAction] At OozieClient.java:[line 1476]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$WorkflowActionInfo.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$WorkflowActionInfo] At OozieClient.java:[line 1025]
[INFO] Found reliance on default encoding in org.apache.oozie.client.OozieClient$WorkflowActionRetriesInfo.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.OozieClient$WorkflowActionRetriesInfo] At OozieClient.java:[line 1046]
[INFO] Found reliance on default encoding in org.apache.oozie.client.XOozieClient.readScript(String): new java.io.FileReader(String) [org.apache.oozie.client.XOozieClient] At XOozieClient.java:[line 81]
[INFO] Found reliance on default encoding in org.apache.oozie.client.XOozieClient$HttpJobSubmit.call(HttpURLConnection): new java.io.InputStreamReader(InputStream) [org.apache.oozie.client.XOozieClient$HttpJobSubmit] At XOozieClient.java:[line 275]

They should be fixed to get the code more reliable.

Issue Links

• links to: Review Board