[OFBIZ-9578] Collection added to itself

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: Release Branch 14.12, Release Branch 15.12, 16.11.04
• Component/s: framework
• Assignee: Jacques Le Roux
• Reporter: JC
• Created: 14/Aug/17 19:58
• Updated: 16/Aug/17 07:46
• Resolved: 16/Aug/17 07:46

Description

Hi

In a recent github mirror, I've found suspicious code.
Branch: master
path: framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/DatabaseUtil.java

...
1588         protected final List<String> messages = new LinkedList<String>();
...
1596         protected int updateData(Collection<String> messages) {
1597             if (messages != null && UtilValidate.isNotEmpty(this.messages)) {
1598                 messages.addAll(messages);
1599             }
1600             return count;
1601         }
1602     }

In Line 1598, `messages.addAll' should be `this.messages.addAll'? This might not be an issue but I wanted to report this just in case.

Thanks!