[OFBIZ-6347] Two order payment preferences are added to order, when order of order total 0(zero) is placed with Billing Account

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 14.12.01, Trunk
• Fix Version/s: 14.12.01, 12.04.06, 13.07.03, 16.11.01
• Component/s: order
• Sprint: Community Day 2 - 2015
• Assignee: Arun Patidar
• Reporter: Mohammad Kathawala
• Created: 08/May/15 11:56
• Updated: 01/Aug/15 09:03
• Resolved: 20/Jun/15 11:27

Description

Scenario:
Place an order of order total zero(0) with Billing Account as payment option.
Issue:
Order gets placed successfully, but order payment preference of billing account gets created twice.

Steps to generate the issue:
1) Add promotions of Free Shipping and Free Tax from catalog for order
2) Go to order entry process and add customer
3) Add product to order and make its price 0.00 so that the cart total will be 0.00
4) Finalize order with Billing Account as Payment option and Create Order.

Reason:

The code written for creating order payment preferences in 'makeAllOrderPaymentInfos' of ShoppingCart.java is creating issue.

There is no need to create the order payment preference after recalculating Billing account amount as it is done later in the CartPaymentInfo loop.