[NIFI-5196] AbstractJMSProcessor can leave connection hanging open

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6.0
• Fix Version/s: 1.8.0
• Component/s: Extensions
• Labels: JMS
• Assignee: Michael W Moser
• Reporter: Nick Coleman
• Created: 15/May/18 19:25
• Updated: 18/Jul/18 15:00
• Resolved: 18/Jul/18 09:28

Description

ConsumeJMS and PublishJMS are based on AbstractJMSProcessor.  They can cause a connection to the MQ Server to be opened and not be closed until the NiFi server is rebooted.

This can create a problem for an MQ when the initial setup entered is wrong for an IBM MQ system that only allows one connection per user.  Subsequent connections are blocked as the first remains open.  Another potential problem even if the subsequent connection works is the original connection is still open and taking up resources.

A simple change to the AbstractJMSProcessor would be in the onTrigger() function:

 

@Override
public void onTrigger(ProcessContext context, ProcessSession session) throws ProcessException {
    T worker = workerPool.poll();
    if (worker == null) {
        worker = buildTargetResource(context);
    }

    boolean offered = false;
    try {
        rendezvousWithJms(context, session, worker);
        offered = workerPool.offer(worker);
    }
    finally {
        if (!offered) {
            worker.shutdown();
        }
    }
}

 

Issue Links

• links to: GitHub Pull Request #2904