Issue Details (XML | Word | Printable)

Key: NET-71
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Unassigned
Reporter: William Noto
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Commons Net

[net][PATCH] "MVS is the operating system of this server. FTP Server is running on z/OS."

Created: 08/Apr/05 05:33 AM   Updated: 20/Sep/07 05:31 AM
Return to search
Component/s: None
Affects Version/s: Nightly Builds
Fix Version/s: None

Time Tracking:
Not Specified

File Attachments:
  Size
Text File commons-net-MVSFTPEntryParser-patch.txt 2005-04-08 05:34 AM William Noto 11 kB
Environment:
Operating System: All
Platform: All

Bugzilla Id: 34360


 Description  « Hide
Jeff Nadler created the original fix to this issue and I wrote the test case. I
will post the patch directly.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
William Noto added a comment - 08/Apr/05 05:34 AM
Created an attachment (id=14649)
This fixes the MVS FTP issue.

William Noto added a comment - 08/Apr/05 06:38 AM
The attached patch fixes this.

Steve Cohen added a comment - 08/Apr/05 10:23 AM
This bug cannot be marked as fixed - your code has not yet been accepted into
the commons-net project yet. However, I see no problem in its being accepted,
and when it is, this bug can close.

Steve Cohen added a comment - 09/Apr/05 03:51 AM
Now it can be called "fixed". I have committed your new parser to SVN and it is
part of the project. Thank you both for your excellent contributions. This is
how Open Source is supposed to work.

I made a couple of minor changes to your code so that it might fit better into
the hierarchy. I made your parser class a subclass of
ConfigurableFTPFileEntryParserImpl (which may not have been around at the time
you originally wrote this) and I made your test class a subclass of
FTPParseTestFramework which is more appropriate than the original
CompositeFTPParseTestFramework (the latter is for parsers that are "polymorphic"

  • for example, NT's parser which can be configured either in the native NT
    format or the UNIX format).

You guys might want to submit more patches if and when you get a chance, if you
learn any more about how timestamps and directories are handled.

Again, thanks.


Steve Cohen added a comment - 18/Apr/05 06:09 AM
      • COM-1438 has been marked as a duplicate of this bug. ***