[NET-543] net: telnet: spy read EOL is reversed

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.3
• Fix Version/s: 3.4
• Component/s: Telnet

Environment

Linux x64

• Assignee: Unassigned
• Reporter: Ferry Huberts
• Created: 05/Jun/14 11:52
• Updated: 26/Nov/15 16:34
• Resolved: 07/Jun/14 16:20

Description

the code in Telnet::_spyRead has a bug that results in a 'reversed' EOL.
I'm expecting SocketClient.NETASCII_EOL (\r\n) but I'm getting '\n\r'.

the code

    void _spyRead(int ch)
    {
        OutputStream spy = spyStream;
        if (spy != null)
        {
            try
            {
                if (ch != '\r')
                {
                    spy.write(ch);
                    if (ch == '\n')
                    {
                        spy.write('\r');
                    }
                    spy.flush();
                }
            }
            catch (IOException e)
            {
                spyStream = null;
            }
        }
    }

should be replaced by

    void _spyRead(int ch)
    {
        OutputStream spy = spyStream;
        if (spy != null)
        {
            try
            {
                if (ch != '\r')
                {
                    if (ch == '\n')
                    {
                        spy.write('\r');
                    }
                    spy.write(ch);
                    spy.flush();
                }
            }
            catch (IOException e)
            {
                spyStream = null;
            }
        }
    }