TFTPClient.setMaxTimeouts() param check broken

• Key: NET-52
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Unassigned
• Reporter: Steve Weiland
• Affects Version/s: Nightly Builds

Environment

Operating System: All
Platform: All

Description

The input check on this method inspects the instance variable it is
going to set not the input received.

Index: TFTPClient.java
===================================================================
RCS file: /home/cvspublic/jakarta-commons/net/src/java/org/apache/commons/net/
tftp/TFTPClient.java,v
retrieving revision 1.14
diff -u -r1.14 TFTPClient.java
— TFTPClient.java 29 Jun 2004 04:54:31 -0000 1.14
+++ TFTPClient.java 23 Sep 2004 13:55:24 -0000
@@ -86,7 +86,7 @@
***/
public void setMaxTimeouts(int numTimeouts)
{

• if (__maxTimeouts < 1)
  + if (numTimeouts < 1)
  __maxTimeouts = 1;
  else
  __maxTimeouts = numTimeouts;

Comments

[Rory Winston]

Fixed in CVS. Thanks.