[NET-456] [net] TelnetClient hangs when reader-thread startup delays

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.1
• Fix Version/s: 3.2
• Component/s: Telnet
• Assignee: Unassigned
• Reporter: MarikoSekiguchi
• Created: 21/Mar/12 06:08
• Updated: 17/Apr/13 19:57
• Resolved: 14/Jul/12 13:58

Description

I'm trying to use TelnetClient(commons-net-3.1) with the reader-thread enabled,
but it sometimes hangs.

I tracked "__receiveState", and found that the state sometimes changes to invalid ones.

In threaded-mode, TelnetInputStream.__read(boolean mayBlock) is normally called only by TelnetInputStream.run().
But if the read-thread startup delays, it may also called by TelnetInputStream.read()
beacues the value of __threaded is still false.

example of hang-up pattern

1.
// user-thread
telnetClient._connectAction()
TelnetInputStream._start()
__thread.start(); ... try to start read-thread

2.
// user-thread
TelnetInputStream.read() ... _threaded is still false, so TelnetInputStream._read() is called.

3.
// read-thread starts (before __read() above dosen't end )
TelnetInputStream.run( ) ... sets _threaded to true, and calls TelnetInputStream._read()

I think __threaded flag should be set to true just after __thread.start(),
not at the begining of run().

__thread.start();
__threaded = true; // add

This problem may related to NET-73