Issue Details (XML | Word | Printable)

Key: NET-41
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Unassigned
Reporter: poitypoity@hotmail.com
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Commons Net

ftp transfer resume not working with passive mode.

Created: 23/Jul/03 05:26 AM   Updated: 20/Sep/07 05:31 AM
Return to search
Component/s: None
Affects Version/s: 1.0
Fix Version/s: None

Time Tracking:
Not Specified

Environment:
Operating System: All
Platform: All

Bugzilla Id: 21815


 Description  « Hide
subject says it all: I think you just omitted the following code in
ftpclient.java:

instead of:
socket = socketFactory.createSocket(__passiveHost, __passivePort);

if (!FTPReply.isPositivePreliminary(sendCommand(command, arg)))
{ socket.close(); return null; }

should read:

socket = socketFactory.createSocket(__passiveHost, __passivePort);

if ((_restartOffset > 0) && !restart(_restartOffset))
{ socket.close(); return null; } }

if (!FTPReply.isPositivePreliminary(sendCommand(command, arg)))

{ socket.close(); return null; }

That is, you just forgot a simple clause (which I adapted from the active mode
code). I tested it (basically) and it works.
hope this helps your excellent project.



 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Daniel Savarese added a comment - 23/Jul/03 08:44 PM
Report looks valid. I applied the appropriate changes.