[NET-307] One of the "connect" method in class org.apache.commons.net.SocketClient doesn't handle connection timeout properly

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0
• Fix Version/s: 2.0

Environment

Not applicable

• Assignee: Unassigned
• Reporter: sg
• Created: 12/Jan/10 03:46
• Updated: 31/Mar/10 18:05
• Resolved: 08/Mar/10 09:37

Description

org.apache.commons.net.SocketClient method connect (line 225) doesn't use the configured timeout value.

Original code:

SocketClient.java (line 225)

    public void connect(String hostname, int port,
                        InetAddress localAddr, int localPort)
    throws SocketException, IOException
    {
        _socket_ = _socketFactory_.createSocket(hostname, port, localAddr, localPort);
        _connectAction_();
    }

Working alternative:

SocketClient.java (line 225)

    public void connect(String hostname, int port,
                        InetAddress localAddr, int localPort)
    throws SocketException, IOException
    {
        _socket_ = _socketFactory_.createSocket();
        _socket_.bind(new InetSocketAddress(localAddr, localPort));
        _socket_.connect(new InetSocketAddress(hostname, port), connectTimeout);
        _connectAction_();
    }