[NET-250] DefaultFTPFileEntryParserFactory Does not work with Netware FTP server returning "NETWARE TYPE: L8"

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.2
• Assignee: Unassigned
• Reporter: James Hayes
• Created: 18/Dec/08 13:07
• Updated: 15/Oct/10 09:20
• Resolved: 05/Feb/09 00:26

Description

We have just being trying to upgrade from the old NetComponents-1.3.8 to the new apache commons-net-2.0 The only thing we really needed to do is to change some imports and our project compiled.

The problem is that listFiles does not work any more with our netware ftp server! I have done some debugging and found that the problem is when creating a FTPFileEntryParser from the class DefaultFTPFileEntryParserFactory it returns a Unix entry parser due the code:

            if ((ukey.indexOf(FTPClientConfig.SYST_UNIX) >= 0) 
	            		|| (ukey.indexOf(FTPClientConfig.SYST_L8) >= 0))
	            {
	                parser = createUnixFTPEntryParser();
	            }

I understand that the SYST_L8 is used to identify that the system is unknown and so per default takes the UNIX server, however our FTP server returns "NETWARE TYPE: L8" and should really be identified as a netware server. maybe this L8 test could be done at the end of these massive if, else statements?

In the meanwhile i have created by own FTPFileEntryParserFactory which does this and it works. The question is, is it a bug and should this change also be done in the commons?