[NET-223] the data connection socket is not closed when an IOException occurred

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4
• Fix Version/s: 2.0

Environment

Windows

• Assignee: Unassigned
• Reporter: Toshiaki Masaki
• Created: 19/Jun/08 08:34
• Updated: 04/Jun/11 19:24
• Resolved: 19/Jun/08 12:12

Description

In method FTPClient.initiateListParsing(FTPFileEntryParser, String),
the data connection socket is not closed when an IOException(e.g. SocketTimeoutException)
occurred while calling FTPListParseEngine.readServerList().

> engine.readServerList(socket.getInputStream(), getControlEncoding());
> socket.close();

In other methods that open a data connection socket, like retrieveFile() and __storeFile(),
the socket is closed when an IOException occurred.

I think, the client should close the socket like the following.

> try

{ > engine.readServerList(socket.getInputStream(), getControlEncoding()); > }

finally {
> socket.close();