FTPTimestampParserImpl#parseTimeStamp() is not fully testable

• Key: NET-198
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Unassigned
• Reporter: Sebb
• Fix Version/s: 2.0, 1.5

Description

The FTPTimestampParserImpl#parseTimeStamp() method is not fully testable, because it unconditionally creates Calendar items using the current time.

In order to test for leap years and DST, the test code needs to be able to set arbitrary times.

I suggest adding a package-private method that takes an additional Calendar parameter, as follows:

Calendar parseTimestamp(String timestampStr, Calendar now) throws ParseException {
// etc

This would replace the original code; the public interface would delegate to the package-private method:

public Calendar parseTimestamp(String timestampStr) throws ParseException { Calendar now = Calendar.getInstance(); return parseTimestamp(timestampStr, now); }

Patch to follow.

Comments

It's not possible to test fixes to NET-188 without this patch

[Sebb]

Patch needs adjusting

[Sebb]

The original patch was changed slightly when it was applied, and one of the lines was moved to the wrong method.

Also, it's important that the fix to the year is taken from the provided year, not the current year (which may be different in testing).
This was omitted in the original patch.