[#NET-177] FTPClient fails to parse valid PASV responses

Commons Net

FTPClient fails to parse valid PASV responses

Created: 16/Dec/07 10:32 AM Updated: 18/Feb/08 12:07 AM

Return to search

Component/s:

None

Affects Version/s:

1.4, 2.0, 1.5

Fix Version/s:

2.0

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	FTPClient_parsePassive.diff	2007-12-16 10:48 AM	Chris Eagle	3 kB

Environment:

All, this is a source problem, not an environment problem

Resolution Date:

18/Feb/08 12:07 AM

Description

« Hide

The FTPClient.__parsePassiveModeReply function expects PASV mode parameters to be enclosed in parenthesis. While this is often the case, it is not a requirement and parsing fails with a StringIndexOutOfBoundsException when PASV mode parameters are not enclosed in parenthesis.

Please refer to RFC 1123 section 4.1.2.6 for more information.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Repository	Revision	Date	User	Message
ASF	#403355	Wed Jul 28 23:21:24 UTC 2004	aadamchik	~~NET-177~~, etc
				Files Changed
				MODIFY /incubator/cayenne/main/trunk/cayenne/src/modeler/java/org/objectstyle/cayenne/modeler/EventController.java MODIFY /incubator/cayenne/main/trunk/cayenne/src/modeler/java/org/objectstyle/cayenne/modeler/action/ImportDbAction.java MODIFY /incubator/cayenne/main/trunk/cayenne/src/cayenne/java/org/objectstyle/cayenne/access/DbLoader.java MODIFY /incubator/cayenne/main/trunk/cayenne/src/modeler/java/org/objectstyle/cayenne/modeler/ProjectTreeView.java MODIFY /incubator/cayenne/main/trunk/cayenne/src/modeler/java/org/objectstyle/cayenne/modeler/action/ImportEOModelAction.java

[ Permlink | « Hide ]

Chris Eagle added a comment - 16/Dec/07 10:48 AM

This is a patch for the issue that depends on the following java features introduced in JDK 1.4:
java.util.regex.Pattern
java.util.regex.Matcher
String.split

Chris Eagle made changes - 16/Dec/07 10:48 AM

Field	Original Value	New Value
Attachment		FTPClient_parsePassive.diff [ 12371747 ]

[ Permlink | « Hide ]

Rory Winston added a comment - 18/Feb/08 12:07 AM

Patch applied. Thanks.

Rory Winston made changes - 18/Feb/08 12:07 AM

Fix Version/s		2.0 [ 12312040 ]
Status	Open [ 1 ]	Closed [ 6 ]
Resolution		Fixed [ 1 ]