[net] POP3Client ProtocolCommandListener protocolReplyReceived method event.getMessage() is empty/blank

• Key: NET-104
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Unassigned
• Reporter: Dave Cee
• Affects Version/s: Nightly Builds

Environment

Operating System: All
Platform: All

Description

Using POP3Client.addProtocolCommandListener, when the listener's
protocolReplyReceived method is called with a ProtocolCommandEvent object, the
getMessage() method of this object returns a blank string. It should return the
reply string. Caused by POP3.__getReply() calling the listener before it has
saved the reply string in _replyLines.

Pseudocode example:

public class TestPOP3 implements ProtocolCommandLister
{
public void connect()

{ POP3Client client = new POP3Client(); client.addProtocolCommandListener(this); client.connect(emailServer); client.login(emailUsername, emailPassword); client.disconnect(); }

public void protocolCommandSent(ProtocolCommandEvent vent)

{ log.debug(">" + event.getMessage()); }

public void protocolReplyReceived(ProtocolCommandEvent vent)

{ // bug: event.getMessage() is always an empty string ere log.debug("<" + event.getMessage()); }

}

Comments

[Dave Cee]

Created an attachment (id=14536)
Suggested patch for POP3.java, diff on 1.3.0 source

[Dave Cee]

(From update of attachment 14536)
>--- POP3.java 2005-03-22 16:39:31.974738700 +0000
>+++ POP3.java 2005-03-22 16:41:29.273405900 +0000
>@@ -124,11 +124,11 @@
> MalformedServerReplyException(
> "Received invalid POP3 protocol response from server.");
>
>- if (commandSupport.getListenerCount() > 0)
>- commandSupport.fireReplyReceived(_replyCode, getReplyString());
>-
> _replyLines.addElement(line);
> _lastReplyLine = line;
>+
>+ if (commandSupport.getListenerCount() > 0)
>+ commandSupport.fireReplyReceived(_replyCode, getReplyString());
> }
>

[Dave Cee]

(From update of attachment 14536)
>--- POP3.java 2005-03-22 16:39:31.974738700 +0000
>+++ POP3.java 2005-03-22 16:41:29.273405900 +0000
>@@ -124,11 +124,11 @@
> MalformedServerReplyException(
> "Received invalid POP3 protocol response from server.");
>
>- if (commandSupport.getListenerCount() > 0)
>- commandSupport.fireReplyReceived(_replyCode, getReplyString());
>-
> _replyLines.addElement(line);
> _lastReplyLine = line;
>+
>+ if (commandSupport.getListenerCount() > 0)
>+ commandSupport.fireReplyReceived(_replyCode, getReplyString());
> }
>

[Dave Cee]

Sorry, I'm a Bugzilla newbie, ignore the comments about the edits of the patch file.

[Daniel Savarese]

Thanks. I applied the fix. Please verify before closing.