[#MODPYTHON-93] Improve util.FieldStorage efficiency

mod_python

Improve util.FieldStorage efficiency

Created: 27/Nov/05 05:35 AM Updated: 02/Apr/07 11:40 AM

Return to search

Component/s:

core

Affects Version/s:

3.2.7

Fix Version/s:

3.3.1

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	modpython325_util_py_dict.patch	2005-12-02 03:47 PM	Mike Looijmans	8 kB

Resolution Date:

22/Nov/06 11:18 AM

Description

« Hide

Form fields are saved as a list in a FieldStorage class instance. The class implements a __getitem__ method to provide dict-like behaviour. This method iterates over the complete list for every call to __getitem__. Applications that need to access all the fields when processing the form will show O(n^2) behaviour where n == the number of form fields. This overhead could be avoided by creating a dict (to use as an index) when the FieldStorage instance is created.

Mike Looijmans has been investigating StringField and Field as well. It is probably reasonable to include information on his work in this issue as well, so that we can consider all of these efficiency issues in toto.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Mike Looijmans made changes - 02/Dec/05 03:47 PM

Field	Original Value	New Value
Attachment		modpython325_util_py_dict.patch [ 12321091 ]

Nicolas Lehuen made changes - 29/Dec/05 04:59 AM

Fix Version/s		3.3 [ 12310101 ]
Affects Version/s	3.3 [ 12310101 ]
Affects Version/s		3.2 [ 11060 ]

Jim Gallacher made changes - 22/Mar/06 11:31 AM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Jim Gallacher made changes - 30/Jun/06 09:14 AM

Status	Resolved [ 5 ]	Reopened [ 4 ]
Resolution	Fixed [ 1 ]

Graham Dumpleton made changes - 24/Oct/06 05:54 AM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Graham Dumpleton made changes - 26/Oct/06 10:21 AM

Assignee	Jim Gallacher [ jgallacher ]	Graham Dumpleton [ grahamd ]
Status	Resolved [ 5 ]	Reopened [ 4 ]
Resolution	Fixed [ 1 ]

Graham Dumpleton made changes - 26/Oct/06 10:21 AM

Status

Reopened [ 4 ]

In Progress [ 3 ]

Graham Dumpleton made changes - 05/Nov/06 06:49 AM

Resolution		Fixed [ 1 ]
Status	In Progress [ 3 ]	Resolved [ 5 ]

Graham Dumpleton made changes - 21/Nov/06 10:50 PM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Graham Dumpleton made changes - 21/Nov/06 10:50 PM

Status

Reopened [ 4 ]

In Progress [ 3 ]

Graham Dumpleton made changes - 22/Nov/06 11:18 AM

Resolution		Fixed [ 1 ]
Status	In Progress [ 3 ]	Resolved [ 5 ]

Graham Dumpleton made changes - 02/Apr/07 11:40 AM

Status

Resolved [ 5 ]

Closed [ 6 ]