Issue Details (XML | Word | Printable)

Key: MODPYTHON-38
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Graham Dumpleton
Reporter: Graham Dumpleton
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
mod_python

Passing req.form into psp.PSP().

Created: 21/Mar/05 06:08 AM   Updated: 02/Apr/07 11:15 AM
Return to search
Component/s: core
Affects Version/s: 3.1.4
Fix Version/s: 3.3.1

Time Tracking:
Not Specified

Resolution Date: 30/Jul/06 04:22 AM


 Description  « Hide
When calling psp.PSP() explicitly to render PSP pages, it will internally setup
req.form if it determines that the form is accessed by the PSP page.

Problem is that if you are wanting to trigger psp.PSP() from a publisher function
any form parameters have already been processed and req.form created. For a
POST request this is problematic as in doing this it will have consumed all the
content of the request.

This means that when the form is processed a second time by psp.PSP(), it will
find no request content. Thus, the PSP page will only be able to make use of
GET form parameters and not POST form parameters.

It would be an improvement if psp.PSP() allowed a instance of util.FieldStorage
which has previously been created to be passed in through the "form" parameter
of the constructor. Ie.,

    template = psp.PSP(req,filename=path,vars=settings,form=req.form)
    template.run()


 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Repository Revision Date User Message
ASF #191745 Tue Jun 21 23:35:59 UTC 2005 jgallacher Changed run() to call req.get_session() when it needs to create a session.
If a session was previously created with req.get_session(), the current session instance is returned, other wise a new one is created.
This solves potential deadlock issues if the user previously created a session and called run() without unlocking the session.
Ref MODPYTHON-38
Files Changed
MODIFY /httpd/mod_python/trunk/lib/python/mod_python/psp.py

Repository Revision Date User Message
ASF #426865 Sun Jul 30 04:22:17 UTC 2006 grahamd MODPYTHON-38) Fixed issue when using PSP pages in conjunction with
publisher handler or where a PSP error page was being triggered, that form
parameters coming from content of a POST request weren't available or only
available using a workaround. Specifically, the PSP page will now use any
FieldStorage object instance cached as req.form left there by preceding
code.
Files Changed
MODIFY /httpd/mod_python/trunk/Doc/modpython4.tex
MODIFY /httpd/mod_python/trunk/lib/python/mod_python/psp.py
MODIFY /httpd/mod_python/trunk/lib/python/mod_python/__init__.py
MODIFY /httpd/mod_python/trunk/Doc/appendixc.tex
MODIFY /httpd/mod_python/trunk/src/include/mpversion.h