apply_fs_data() does not work with "new style" objects

• Key: MODPYTHON-25
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: Nicolas Lehuen
• Reporter: Bruno Desthuilliers
• Affects Version/s: 3.1.3
• Fix Version/s: 3.2.7

Description

util.py v.1.21, apply_fs_data()

Trying to publish instances of a new style class, you get an exception
(UnboundLocalError: local variable 'fc' referenced before assignment)
pointing to util.py, line 356

What happens is that the test line 336 doesn't work for new style classes, letting the code fallback to line 356 without fc being defined.

The fix is pretty trivial: rewrite line 336 as:
    if type(obj) is InstanceType or isinstance(obj, object):

Which leads to a second fix: the first arg of the function is named 'object', which seems sensible, but is also the name of the new style classes base class, so s/object/obj/ in that code is also needed.

Comments

[Nicolas Lehuen]

This bug is already fixed by all the prospective work done during January about the security issue. A unit test was added to check for it.