ReportError in importer.py raises an exception for mal-formed psp

• Key: MODPYTHON-201
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Blocker
• Assignee: Unassigned
• Reporter: Jim Gallacher
• Component/s: importer
• Affects Version/s: 3.3.x
• Fix Version/s: 3.3.1

Description

Mal formed psp causes an exception in importer.py ReportError

The following psp contains a syntax error, and generates an exception as expected, causing importer.ReportError to be called.

test.psp
-------------
<%
req.write('x'
%>

There is bug in ReportError however that raises an exception, and a 500 Internal Server Error is sent to the client.

apache error_log
--------------------------
[Fri Nov 03 16:08:19 2006] [error] [client 192.168.1.2] req.write("""
[Fri Nov 03 16:08:19 2006] [error] [client 192.168.1.2] ^
[Fri Nov 03 16:08:19 2006] [error] [client 192.168.1.2] SyntaxError: invalid syntax
Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/mod_python/importer.py", line 1797, in ReportError
    stime = time.asctime(time.localtime(modules.stime))
AttributeError: '_module_cache' object has no attribute 'stime'
[Fri Nov 03 16:08:19 2006] [error] [client 192.168.1.2] python_handler: Dispatch() returned non-integer.

I'm not sure if this is a simple bug in ReportError, or indicates a deeper problem with cache mechanism in the importer.

Comments

[Jim Gallacher]

Already fixed in a more recent commit.