[#MODPYTHON-190] python 2.5 support

mod_python

python 2.5 support

Created: 19/Sep/06 06:35 PM Updated: 24/Oct/06 05:56 AM

Return to search

Component/s:

core

Affects Version/s:

3.3.x

Fix Version/s:

None

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	ssizecheck.diff	2006-10-20 01:37 PM	Jim Gallacher	0.7 kB

Environment:

All

Description

« Hide

Python 2.5 has been offically released, The major change that may effect mod_python is better support for 64-bit machines, allowing for things such as strings > 2GiB.

Details and conversion guidelines can be found in PEP-353.
http://www.python.org/dev/peps/pep-0353/

Scanning the mod_python source with the ssizecheck.py script mentioned in the PEP indicates a number of places that will require attention.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Repository	Revision	Date	User	Message
ASF	#466105	Fri Oct 20 13:28:02 UTC 2006	jgallacher	(MODPYTHON-190) Added comments for lines of code which will require attention for Python 2.5 / 64-bit support. These were the lines that were identified by the ssizecheck.py script.
				Files Changed
				MODIFY /httpd/mod_python/trunk/src/util.c MODIFY /httpd/mod_python/trunk/src/_apachemodule.c MODIFY /httpd/mod_python/trunk/src/filterobject.c MODIFY /httpd/mod_python/trunk/src/tableobject.c MODIFY /httpd/mod_python/trunk/src/requestobject.c MODIFY /httpd/mod_python/trunk/src/connobject.c MODIFY /httpd/mod_python/trunk/src/finfoobject.c

[ Permlink | « Hide ]

Jim Gallacher added a comment - 20/Oct/06 01:37 PM

ssizecheck.py will include functions which are enclosed in comments in its output. Since I've added comments to mod_python src code to mark the areas which may need attention, ssizecheck.py will now give many false positives.

The attached patch ssizecheck.diff contains a small modification which will skip any comment that starts with "/* PYTHON 2.5:"

eg

/* PYTHON 2.5: PyTuple_New uses Py_ssize_t for input parameters */

The addition of these comments will allow us to keep track of the code areas which will need attention for full python 2.5 / 64-bit support.

Jim Gallacher made changes - 20/Oct/06 01:37 PM

Field	Original Value	New Value
Attachment		ssizecheck.diff [ 12343363 ]

[ Permlink | « Hide ]

Graham Dumpleton added a comment - 24/Oct/06 05:56 AM

Taking this off the list of things to fix in 3.3. We really need someone who has access to Python 2.5 and a 64 bit platform to help us do this one and test it. Until then we could do more harm than good if we start fiddling with the code with no way to actually validate it works ourselves.

Graham Dumpleton made changes - 24/Oct/06 05:56 AM

Fix Version/s

3.3 [ 12310101 ]