python 2.5 support

• Key: MODPYTHON-190
• Type: Task
• Status: Open
• Priority: Major
• Assignee: Unassigned
• Reporter: Jim Gallacher
• Component/s: core
• Affects Version/s: 3.3.x

Description

Python 2.5 has been offically released, The major change that may effect mod_python is better support for 64-bit machines, allowing for things such as strings > 2GiB.

Details and conversion guidelines can be found in PEP-353.
http://www.python.org/dev/peps/pep-0353/

Scanning the mod_python source with the ssizecheck.py script mentioned in the PEP indicates a number of places that will require attention.

Comments

ssizecheck.py will include functions which are enclosed in comments in its output. Since I've added comments to mod_python src code to mark the areas which may need attention, ssizecheck.py will now give many false positives.

The attached patch ssizecheck.diff contains a small modification which will skip any comment that starts with "/* PYTHON 2.5:"

eg

/* PYTHON 2.5: PyTuple_New uses Py_ssize_t for input parameters */

The addition of these comments will allow us to keep track of the code areas which will need attention for full python 2.5 / 64-bit support.

[Graham Dumpleton]

Taking this off the list of things to fix in 3.3. We really need someone who has access to Python 2.5 and a 64 bit platform to help us do this one and test it. Until then we could do more harm than good if we start fiddling with the code with no way to actually validate it works ourselves.