Issue Details (XML | Word | Printable)

Key: MODPYTHON-185
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Jim Gallacher
Reporter: Thomas Hervé
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
mod_python

_psp.parsestring doesn't check for empty values

Created: 15/Aug/06 01:59 PM   Updated: 01/May/07 10:42 AM
Return to search
Component/s: psp
Affects Version/s: None
Fix Version/s: 3.3.1

Time Tracking:
Not Specified

File Attachments:
  Size
File _pspmodule.diff 2006-08-15 01:59 PM Thomas Hervé 0.5 kB
Environment: All

Resolution Date: 15/Aug/06 04:20 PM


 Description  « Hide
The function _psp_module_parsestring of _pspmodule.c doesn't check the value of parser->pycode.blob when calling PyString_FromString (whereas it's done in _psp_module_parse). When called with an empty string it can cause a segfault (blob is NULL and PyString_FromString doesn't check for NULL value).

I attach a simple diff correcting the problem.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Jim Gallacher made changes - 15/Aug/06 04:08 PM
Field Original Value New Value
Assignee Jim Gallacher [ jgallacher ]
Jim Gallacher made changes - 15/Aug/06 04:08 PM
Status Open [ 1 ] In Progress [ 3 ]
Jim Gallacher made changes - 15/Aug/06 04:20 PM
Resolution Fixed [ 1 ]
Fix Version/s 3.3 [ 12310101 ]
Status In Progress [ 3 ] Resolved [ 5 ]
Repository Revision Date User Message
ASF #431636 Tue Aug 15 16:22:19 UTC 2006 jgallacher Fixed segfault in psp.parsestring(src) where src = "".
(MODPYTHON-185)
Files Changed
MODIFY /httpd/mod_python/trunk/src/_pspmodule.c
MODIFY /httpd/mod_python/trunk/Doc/appendixc.tex

Graham Dumpleton made changes - 01/May/07 10:42 AM
Status Resolved [ 5 ] Closed [ 6 ]