Make name of mutex directory configurable.

• Key: MODPYTHON-131
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Jim Gallacher
• Reporter: Graham Dumpleton
• Component/s: core
• Affects Version/s: 3.2.7
• Fix Version/s: 3.2.10, 3.3.1

Description

Creating an issue for this so it can be tracked.

Been pointed out in:

  http://www.mail-archive.com/[e-mail]/msg01271.html

that on Mandriva Linux, that is is necessary to manually change the mutex directory in mod_python.c source code. Area of code is:

  #if !defined(OS2) && !defined(WIN32) && !defined(BEOS) && !defined(NETWARE)
        char fname[255];

        snprintf(fname, 255, "/tmp/mpmtx%d%d", glb->parent_pid, n);
  #else
        char *fname = NULL;
  #endif

There should be an option to configure program to allow this to be more easily changed.

Way of changing the value through Apache configuration to also be investigated further.

Comments

In respect of:

  http://svn.apache.org/viewcvs/httpd/mod_python/trunk/src/include/mod_python.h.in?rev=385000&r1=384999&r2=385000&view=diff

I think you probably want:

/* MUTEX_DIR can be set as a configure option
 * ./configure --with-mutex-dir=/path/to/dir
 */
#define MUTEX_DIR "@MUTEX_DIR@"

Ie., quote value of macro.

And in:

  http://svn.apache.org/viewcvs/httpd/mod_python/trunk/src/mod_python.c?rev=385000&r1=384999&r2=385000&view=diff

you probably want:

        snprintf(fname, 255, "%s/mpmtx%d%d", MUTEX_DIR, glb->parent_pid, n);

Ie., MUTEX_DIR is substituted using %s, as macro will not be expanded in string.

Not sure why tests still pass with the way it was.