Issue Details (XML | Word | Printable)

Key: MODPYTHON-128
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Graham Dumpleton
Reporter: Graham Dumpleton
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
mod_python

Have assigning req.filename automatically update req.finfo.

Created: 10/Feb/06 07:40 AM   Updated: 05/Apr/07 11:49 AM
Return to search
Component/s: core
Affects Version/s: 3.3.x
Fix Version/s: 3.3.1

Time Tracking:
Not Specified

File Attachments:
  Size
File Licensed for inclusion in ASF works MP128_20060423_grahamd_1.diff 2006-04-23 05:39 PM Graham Dumpleton 1 kB
Issue Links:
Blocker
 

Resolution Date: 25/Aug/06 01:07 AM


 Description  « Hide
Although it is possible to assign a new value to "req.filename", it is not possible to update "req.finfo" based on the new filename.

Suggest that if "req.filename" is assigned a new value, that apr_stat() be automatically called to update "req.finfo". Ie., internally mod_python would do something like:

  apr_stat(&r->finfo, r->filename, APR_FINFO_MIN, r->pool);

I believe that mod_perl supports a similar feature, but would need to confirm this.

Related to "req.filename", the "req.canonical_filename" should also be writable as when changing "req.filename" the latter should also by rights be updated as well.



 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Graham Dumpleton made changes - 19/Mar/06 10:39 AM
Field Original Value New Value
Assignee Graham Dumpleton [ grahamd ]
Graham Dumpleton made changes - 19/Mar/06 10:39 AM
Status Open [ 1 ] In Progress [ 3 ]
Graham Dumpleton made changes - 01/Apr/06 01:59 PM
Status In Progress [ 3 ] Open [ 1 ]
Graham Dumpleton made changes - 01/Apr/06 02:16 PM
Link This issue blocks MODPYTHON-123 [ MODPYTHON-123 ]
Graham Dumpleton made changes - 23/Apr/06 05:39 PM
Attachment MP128_20060423_grahamd_1.diff [ 12325728 ]
Graham Dumpleton made changes - 13/Aug/06 11:12 AM
Fix Version/s 3.3 [ 12310101 ]
Graham Dumpleton made changes - 13/Aug/06 11:12 AM
Status Open [ 1 ] In Progress [ 3 ]
Graham Dumpleton made changes - 25/Aug/06 01:07 AM
Resolution Fixed [ 1 ]
Status In Progress [ 3 ] Resolved [ 5 ]
Graham Dumpleton made changes - 05/Apr/07 11:49 AM
Status Resolved [ 5 ] Closed [ 6 ]