[#MODPYTHON-122] configure fails when using bash 3.1.x

mod_python

configure fails when using bash 3.1.x

Created: 07/Feb/06 10:44 PM Updated: 05/Apr/07 11:43 AM

Return to search

Component/s:

core

Affects Version/s:

3.1.4, 3.2.7

Fix Version/s:

3.2.10, 3.3.1

Time Tracking:

Not Specified

Environment:

Any platform using bash 3.1.x

Resolution Date:

06/Mar/06 07:58 AM

Description

« Hide

A bug in bash 3.1 causes configure to fail. This has been reported on recent versions of Gentoo and and discussed on the mod_python mailing list:
http://bugs.gentoo.org/show_bug.cgi?id=118948
http://www.modpython.org/pipermail/mod_python/2006-January/019965.html
http://www.modpython.org/pipermail/mod_python/2006-January/019969.html

According to the gentoo bug report, the problem in configure.in is the double backslash escape sequence in the line:
MP_VERSION=`echo $MP_VERSION | sed s/\\"//g`

Changing this to:
MP_VERSION=`echo $MP_VERSION | sed s/\"//g`
fixes it for bash 3.1.

I wonder why mod_python is using \\" since the gentoo fix seems to work ok with bash 3.0 (and GNU sed) just as well. Is it there to support other shells, other sed versions, older bash versions... ??

I suggest mod_python adopts the gentoo fix, or avoids the problem altogether by using tr. eg.

MP_VERSION=`echo $MP_VERSION | tr -d '"'`

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Jim Gallacher made changes - 07/Feb/06 10:46 PM

Field	Original Value	New Value
Description	A bug in bash 3.1 causes configure to fail. This has been report on recent versions of Gentoo and and deicussed on the mod_python mailing list: http://bugs.gentoo.org/show_bug.cgi?id=118948 http://www.modpython.org/pipermail/mod_python/2006-January/019965.html http://www.modpython.org/pipermail/mod_python/2006-January/019969.html According to the gentoo bug report, the problem in configure.in is the double backslash escape sequence in the line: MP_VERSION=`echo $MP_VERSION \| sed s/\\"//g` Changing this to: MP_VERSION=`echo $MP_VERSION \| sed s/\"//g` fixes it for bash 3.1. I wonder why we are using \\" since the gentoo fix seems to work ok with bash 3.0 (and GNU sed) on my system just as well. Is it there to support other shells, other sed versions, older bash versions... ?? I suggest we either adopt the gentoo fix, or avoid the problem altogether by using tr. eg. MP_VERSION=`echo $MP_VERSION \| tr -d '"'`	A bug in bash 3.1 causes configure to fail. This has been reported on recent versions of Gentoo and and discussed on the mod_python mailing list: http://bugs.gentoo.org/show_bug.cgi?id=118948 http://www.modpython.org/pipermail/mod_python/2006-January/019965.html http://www.modpython.org/pipermail/mod_python/2006-January/019969.html According to the gentoo bug report, the problem in configure.in is the double backslash escape sequence in the line: MP_VERSION=`echo $MP_VERSION \| sed s/\\"//g` Changing this to: MP_VERSION=`echo $MP_VERSION \| sed s/\"//g` fixes it for bash 3.1. I wonder why mod_python is using \\" since the gentoo fix seems to work ok with bash 3.0 (and GNU sed) just as well. Is it there to support other shells, other sed versions, older bash versions... ?? I suggest mod_python adopts the gentoo fix, or avoids the problem altogether by using tr. eg. MP_VERSION=`echo $MP_VERSION \| tr -d '"'`

[ Permlink | « Hide ]

Graham Dumpleton added a comment - 08/Feb/06 07:16 AM

Or as someone else suggested, maybe:

MP_VERSION=`echo $MP_VERSION | sed 's/"//g'`

or:

MP_VERSION=`echo $MP_VERSION | sed 's/["]//g'`

The single quotes should be enough to protect it without needing a slash.

Repository	Revision	Date	User	Message
ASF	#376555	Fri Feb 10 05:03:23 UTC 2006	jgallacher	Fixed configure.in to work correctly with bash 3.1. Ref ~~MODPYTHON-122~~
				Files Changed
				MODIFY /httpd/mod_python/trunk/configure MODIFY /httpd/mod_python/trunk/configure.in

Repository	Revision	Date	User	Message
ASF	#383362	Sun Mar 05 18:05:55 UTC 2006	jgallacher	Backport fix for bash 3.1.x configure problems (~~MODPYTHON-122~~)
				Files Changed
				MODIFY /httpd/mod_python/branches/3.2.x/configure.in MODIFY /httpd/mod_python/branches/3.2.x/configure

Jim Gallacher made changes - 06/Mar/06 07:58 AM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]
Fix Version/s		3.3 [ 12310101 ]

Jim Gallacher made changes - 06/Mar/06 08:32 AM

Fix Version/s	3.3 [ 12310101 ]
Fix Version/s		3.2.x [ 12310860 ]

Graham Dumpleton made changes - 12/Aug/06 07:52 AM

Fix Version/s		3.2.10 [ 12312029 ]
Fix Version/s		3.3 [ 12310101 ]
Fix Version/s	3.2.x [ 12310860 ]

Graham Dumpleton made changes - 05/Apr/07 11:43 AM

Status

Resolved [ 5 ]

Closed [ 6 ]