Issue Details (XML | Word | Printable)

Key: MODPYTHON-109
Type: Bug Bug
Status: Reopened Reopened
Priority: Major Major
Assignee: Graham Dumpleton
Reporter: Graham Dumpleton
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
mod_python

Signal handler calling Py_Finalize() when child processes being killed.

Created: 07/Jan/06 07:53 PM   Updated: 11/May/07 05:10 AM
Return to search
Component/s: core
Affects Version/s: 3.2.7
Fix Version/s: None

Time Tracking:
Not Specified

File Attachments:
  Size
File Licensed for inclusion in ASF works MP109_20060308_grahamd_1.diff 2006-03-08 06:51 PM Graham Dumpleton 5 kB


 Description  « Hide
When Apache is killing off child processes as part of actions taken when the "apachectl restart" or "apachectl graceful" command is run, it sends a SIGTERM signal to the child processes. This causes a signal handler registered by Apache to be run. That signal handler destroys the main child memory pool. That memory pool has though a cleanup handler associated with it which was registered by mod_python. That cleanup handler ultimately calls Py_Finalize().

The problem with this is that Py_Finalize() isn't safe to be called from a signal handler and if a handler is still executing or there is a separate thread running in the context of Python, a deadlock will likely ensue. This will prevent the child process exiting due to the SIGTERM causing the Apache parent process to send it a SIGKILL to really kill it.

For a more detailed assessment of the problem and what lead to this conclusion see:

  http://www.modpython.org/pipermail/mod_python/2006-January/019865.html
  http://www.modpython.org/pipermail/mod_python/2006-January/019866.html
  http://www.modpython.org/pipermail/mod_python/2006-January/019870.html

To avoid the problem, the only choice seems to be avoid calling Py_Finalize() from the signal handler. The simplistic way of doing this seems to be to add:

     if (child_init_pool)
         return APR_SUCCESS;

at the start of python_finalize(). This will mean that Py_Finalize() is never called in child processes. The full consequences of this is unknown, but on face value it would seem that it might be a reasonable thing to do. More research may be required.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Repository Revision Date User Message
ASF #384758 Fri Mar 10 10:38:10 UTC 2006 grahamd The Py_Finalize() function was being called on child process shutdown. This
was being done though from within the context of a signal handler, which is
generally unsafe and would cause the process to lock up. This function is
no longer called on child process shutdown. (MODPYTHON-109)
Files Changed
MODIFY /httpd/mod_python/trunk/test/htdocs/tests.py
MODIFY /httpd/mod_python/trunk/Doc/modpython4.tex
MODIFY /httpd/mod_python/trunk/src/mod_python.c
MODIFY /httpd/mod_python/trunk/Doc/appendixc.tex

Repository Revision Date User Message
ASF #454096 Sun Oct 08 07:24:25 UTC 2006 grahamd (MODPYTHON-109) Amend comment relating to disabling of Python cleanup on
shutdown.
Files Changed
MODIFY /httpd/mod_python/trunk/src/mod_python.c