[METRON-1299] MetronError tests fail if hostname isn't set

• Type: Bug
• Status: Done
• Priority: Major
• Resolution: Done
• Affects Version/s: 0.4.1
• Fix Version/s: 0.5.0
• Environment: openSUSE Tumbleweed 20171102, OpenJDK 1.8.0_144
• Assignee: Otto Fowler
• Reporter: Stuart Bertram
• Created: 06/Nov/17 15:01
• Updated: 22/May/18 19:34
• Resolved: 15/Mar/18 18:23

Description

If I run "mvn package" in the root Metron directory then compilation fails because of a null reference in ./metron-platform/metron-common/src/test/java/org/apache/metron/common/error/MetronErrorTest.java. This happens in getJSONObjectShouldReturnBasicInformation on line 56 because errorJSON.get(Constants.ErrorFields.HOSTNAME.getName()) is assumed to return a string and the length() method is called on it. Because the assert doesn't use a message then no obvious reason why it fails is logged.

The underlying problem is that metron-platform/metron-common/src/main/java/org/apache/metron/common/error/MetronError.java falls through to a catch block in addHostname() when netAddress.getLocalHost().getHostName() exceptions with Name or service not known for the host name.

Setting a hostname that resolves is a build requirement that is out of Metron's control, but if the code specifically handles the fact that it won't always be retrieved then it seems problematic to have tests that assume it works and not make it clear what the failure is when it occurs.

Issue Links

• links to: GitHub Pull Request #924