[METRON-1131] The Stellar REPL rejects valid hostnames for zookeeper in its CLI options

• Type: Bug
• Status: Done
• Priority: Major
• Resolution: Done
• Fix Version/s: 0.4.1
• Assignee: Casey Stella
• Reporter: Casey Stella
• Created: 24/Aug/17 19:39
• Updated: 13/Sep/17 23:50
• Resolved: 13/Sep/17 23:50

Description

Currently, the REPL defines a valid zookeeper hostname is one which matches a regex rather than defining it as a hostname which is reachable by the machine. Combining this with the fact that the regex to validate the hostname is denying valid hostnames:

 @Test
  public void testBadPattern() throws Exception
  {
    Pattern validHostNamePattern = Pattern.compile(
            "^(([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9\\\\-]*[a-zA-Z0-9])\\\\.)"
                    + "*([A-Za-z0-9]|[A-Za-z0-9][A-Za-z0-9\\\\-]*[A-Za-z0-9])$");
    Assert.assertFalse(validHostNamePattern.matcher("gzcf0.fold.blarg.com").matches());
    Assert.assertTrue(validHostNamePattern.matcher("host1").matches());
  }

Issue Links

• links to: GitHub Pull Request #715