[MESOS-7979] reviewboard's GUESS_FIELDS setting leads to redundant information in commit messages

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.6.0
• Labels: mesosphere newbie python
• Story Points: 1
• Assignee: Benjamin Bannier
• Reporter: Benjamin Bannier
• Shepherd: Till Toenshoff
• Created: 14/Sep/17 18:26
• Updated: 26/Mar/18 08:03
• Resolved: 25/Jan/18 14:55

Description

Reviewboard can be set up to automatically guess a patch's summary and description when GUESS_FIELDS is set. For commits that have no dedicated description, it uses the commit summary as description as well. This leads to commits with redundant commit messages, e.g.,

Frobnicated the foobarizer.

Frobnicated the foobarizer.

Review: https://reviews.apache.org/r/1234567890

When applying this commit with e.g., apply_reviews.py the redundant body is faithfully copied, but we should consider updating it to instead remove the redundant information automatically leading to e.g.,

Frobnicated the foobarizer.

Review: https://reviews.apache.org/r/1234567890